feat(pubsub): split GAPIC from the pubsub handwritten package#8854
Merged
Conversation
feywind
added
the
do not merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the auto-generated GAPIC client files and configuration JSONs, delegating them to the newly added external dependency @google-cloud/pubsub-api. However, two critical runtime issues were identified in the review: first, requiring a configuration JSON directly from the src/ directory of @google-cloud/pubsub-api in message-stream.ts will fail when published; second, using a namespace import for p-defer in subscriber.ts will cause a runtime TypeError when invoked.
…n't have service classes anymore
feywind
marked this pull request as ready for review
July 14, 2026 18:17
feywind
removed
the
do not merge
quirogas
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will split out the GAPIC classes into their own package (-api) and change the main handwritten Pub/Sub library to use them instead of a built-in copy.
Internal: b/531797111